Home Forums Xi Theme Discussion & Support ajax-loading ID conflict between Xi and plugin

This topic is: resolved

Tagged: 

This topic contains 2 replies, has 2 voices, and was last updated by  Robert DeGray 4 years, 3 months ago.

Viewing 3 posts - 1 through 3 (of 3 total)
  • Author
    Posts
  • #3250

    Robert DeGray
    Participant
    Post count: 14

    I’m not sure how to resolve this, but we’ve hit yet another global-namespace conflict between Xi and a plugin (Events Calendar Pro). Both use an ID of “ajax-loading” for a spinner type of animated gif, but where the plugin explicitly uses an img and doesn’t style the element, Xi uses a bunch of custom styling, including a background-image and location.

    I was thinking my only workaround that wouldn’t require re-making it on every plugin or theme upgrade would be to override the styles for the ID whenever it appears in the particular location in the DOM that matches where the plugin places it, but that’s going to be a real pain to try to override all those Xi styles. It would be easier to instead make Xi’s style.css qualify it to only where it’s used in the (gallery) pages, but that will get overwritten 🙁

    It seems like there ought be some WordPress guideline here for keeping plugins and themes from stepping on each other? Always use qualified CSS identifiers like los-ajax-loading, maybe?

    Yes, I’ve posted in the plugin’s support forums too. If either had used unique style identifiers, there wouldn’t be an issue. But I think because Xi actually style the ID, you guys have an even greater responsibility to ensure it’s not an ID that could be used anywhere else. The plugin doesn’t style it, just uses it for locating the element later.

    So… any chance a future patch could rename the element and style to prepend a unique qualifier?

    #3251

    themeweaver
    Keymaster
    Post count: 730

    Sure, we’ll take a look at that. It would be easy for us to change that and agree it could be better named.

    We’ll try and release something in the next update.

    #3252

    Robert DeGray
    Participant
    Post count: 14

    Thank you, sir!

Viewing 3 posts - 1 through 3 (of 3 total)

You must be logged in to reply to this topic.